Limit the use of a pointer to the lexical scope of the target #120342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a pointer scope issue by moving the declaration of a stack-allocated string and PKCS12 export parameters struct outside of a conditional block to ensure the pointer remains valid throughout its usage scope.
- Moved stack allocation of algorithm string and struct initialization outside conditional block
- Replaced local variable reference with the outer-scoped variable reference
- Ensured pointer validity by expanding the lexical scope of the target data
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
vcsjones
approved these changes
Oct 3, 2025
jkotas
reviewed
Oct 3, 2025
...ty.Cryptography/src/System/Security/Cryptography/X509Certificates/StorePal.Windows.Export.cs
Outdated
Show resolved
Hide resolved
This was referenced Oct 3, 2025
…/Cryptography/X509Certificates/StorePal.Windows.Export.cs Co-authored-by: Jan Kotas <[email protected]>
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18234052838 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.